kgabryje commented on a change in pull request #18793:
URL: https://github.com/apache/superset/pull/18793#discussion_r819470950
##########
File path:
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
##########
@@ -91,9 +91,9 @@ const DashboardContainer: FC<DashboardContainerProps> = ({
topLevelTabs }) => {
const { scope } = filterScope;
const chartsInScope: number[] = getChartIdsInFilterScope({
filterScope: {
- scope: scope.rootPath,
+ scope: scope?.rootPath,
Review comment:
Good point! I added "optional" operator because in a native filters
array there can be divider objects, which don't have scope. However, we handle
dividers a few lines earlier, so a simple cast was enough to remove those
operators 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
