zhaoyongjie edited a comment on pull request #18794:
URL: https://github.com/apache/superset/pull/18794#issuecomment-1059257704
@cccs-RyanS Thanks for your reply!
> 1. So business types were proposed more to define custom behaviour
that you may want to attach to a column like validation, display and conversion
of values that might not be super straightforward such as dot decimal IP to an
integer. We also want to allow multiple types of input, moving forward with IP
as an example one user might want to type in 1.1.1.1 even though the IP is
stored as an integer, another user may want to type in 16843009 on the same
column. So we want to be able to define a type to handle that.
I am replying to this scenario in point 3. We can use two columns(original
column and derived column) to achieve instead of implicit conversion.
> 2. Yes this PR only covers the input / conversions for filters. Follow
up work will need to be done in order to display the converted values that are
returned from the query. I agree this does mean the current state is a bit
inconsistent. If it is preferred to implement more of the functionality at once
I can do that
Totally agree! We can make
`/superset/filter/<table>/<datasource-id>/<column-name>/` return the coverted
value directly instead of new api: `/v1/business_type/convert` and
`/v1/business_type/types`.
> 3. I agree this does make sense for the port type. The only things to
note is we would like to indicate what values something like ftp represents to
the user, as ftp could potentially mean just 21 but we included 20 as well. we
would also like to preserve the ability for a user to simply type the numeric
version of the port.
I think the finite set we can always make a derived column. we can filter
the original column and the derived column separately. The advantage of this is
the user knows exactly what he is searching for.
```
port,
case
when port = 21 or port = 20 then 'ftp'
...
...
else null
end as port_by_name
```
> 4. Yea extending the operators would help mitigate that issue, however
would that result in a lot of operators as there are quite a few valid cidr
block options
The filter can have a higher abstraction, and I can work with you on that
-----------------
This is a very valuable feature. This allows us to do UDF(User Defined
Function) on the client-side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
