ktmud commented on a change in pull request #18856:
URL: https://github.com/apache/superset/pull/18856#discussion_r819948879
##########
File path:
superset-frontend/src/explore/components/controls/SelectControl.test.jsx
##########
@@ -153,11 +153,12 @@ describe('SelectControl', () => {
});
describe('when select has a sortComparator prop', () => {
- it('does not add add order key and sorts by sortComparator', () => {
Review comment:
This test case expect the child component `Select` to update a prop
passed down from `SelectComponent`, which is a bad practice as all React props
should be immutable.
I didn't see anything breaking after removing this behavior. @corbinrobb
@michael-s-molina do you remember why this was needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
