zhoulijuanmiao commented on pull request #19006:
URL: https://github.com/apache/superset/pull/19006#issuecomment-1059633314


   hi @zhaoyongjie, Thanks for your check, seems like I need to explain the pr 
a bit more specific, as you can see, before my pr, there is a feature of how to 
show bar value labels, **negative value showing on the bottom of the bar, 
positive value showing on the top of the bar**.
   
   **The rule is satisfied in unstacked bar chart, to see it clearly, I set 
filters in all pictures below**
   
   ![Screen Shot 2022-03-05 at 8 25 18 
AM](https://user-images.githubusercontent.com/23090803/156859143-1990831e-3b31-4bc2-8372-ac0aeabf1b09.png)
   
   ![Screen Shot 2022-03-05 at 8 07 19 
AM](https://user-images.githubusercontent.com/23090803/156858566-a7f55ab2-978d-40ee-908e-966e5666676c.png)
   
   **But the rule is not satisfied in stacked bar chart**, my purpose is to fix 
it
   
   ![Screen Shot 2022-03-05 at 8 07 00 
AM](https://user-images.githubusercontent.com/23090803/156860354-5bcb5c23-1a4e-43cb-a0a8-0d4cb6b8bc36.png)
   
   **After my pr, the rule will be satisfied in stacked bar chart, 
additionally, this may make the viz looks better**
   
   ![Screen Shot 2022-03-05 at 8 38 07 
AM](https://user-images.githubusercontent.com/23090803/156860083-8d5b83c8-4703-4f4f-999e-f306b03a1582.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to