cancan101 commented on issue #18993: URL: https://github.com/apache/superset/issues/18993#issuecomment-1061093829
So it looks like https://github.com/apache/superset/pull/18056 did fix the rison encoding meaning that the 400 error is no longer generated by that code path. That being said, if something else does generate a 400 error at some point the view does not correctly handle it and will then raise an error that `response_400` is not defined. This can be tests using a CLI tool and `GET`ing against `/datasource/external_metadata_by_name/` with `q=<invalid rison string>`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
