chanyou0311 opened a new pull request #19059: URL: https://github.com/apache/superset/pull/19059
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixed the problem that JAVASCRIPT TOOLTIP GENERATOR of Deck.gl is not working. I installed `vm-browserify` and specified it in `webpack.config.js`. Because Webpack 5 no longer polyfills and `vm` module is used at `sandboxedEval` function defined `superset/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils/sandbox.js`. > Webpack 5 no longer polyfills Node.js core modules automatically which means if you use them in your code running in browsers or alike, you will have to install compatible modules from npm and include them yourself. > https://webpack.js.org/configuration/resolve/ ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before https://user-images.githubusercontent.com/12185831/157200086-b64eeccf-6e6a-4730-82e5-871590ac32d7.mov #### After https://user-images.githubusercontent.com/12185831/157200116-153f5a57-489b-4e7d-98bc-9ba8c08ea7e6.mov ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/18696 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
