suddjian commented on a change in pull request #19031:
URL: https://github.com/apache/superset/pull/19031#discussion_r822117003
##########
File path: superset-embedded-sdk/src/index.ts
##########
@@ -38,6 +38,8 @@ export type EmbedDashboardParams = {
mountPoint: HTMLElement
/** A function to fetch a guest token from the Host App's backend server */
fetchGuestToken: GuestTokenFetchFn
+ /** The dashboard UI config: hideTitle: 1; hideTab: 2; hideNav: 4;
hideChartControls: 8; **/
+ uiConfig?: number
Review comment:
We should take in individual boolean flags here and construct the
`uiConfig` value automatically, rather than making the caller figure out the
bit logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
