[GitHub] [superset] kgabryje opened a new pull request #19077: perf(dashboard): Send chart requests before native filter requests

[GitBox]

kgabryje opened a new pull request #19077:
URL: https://github.com/apache/superset/pull/19077


   ### SUMMARY
   For performance reasons, when a dashboard loads, native filters requests are 
delayed until chart requests were triggered. However, that's not the case when 
user clicks "Refresh dashboard" button. This PR fixes that issue.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   In the `Network` panel on the right you can see the requests sent after 
clicking "Refresh dashboard". The ones that just say `data` are native filter 
requests. The other ones are chart requests. The goal was to make sure that all 
native filter requests were made after chart requests
   
   Before:
   <img width="1792" alt="image" 
src="https://user-images.githubusercontent.com/15073128/157459238-e4b71f78-4f01-45e3-bcf7-47227d48ff9d.png";>
   
   After:
   <img width="1792" alt="image" 
src="https://user-images.githubusercontent.com/15073128/157458952-e44a2ab9-2d0b-4444-8e7c-0e82767077ec.png";>
   
   
   ### TESTING INSTRUCTIONS
   1. Create a dashboard with multiple charts and native filters
   2. Open Chrome dev tools network tab
   3. Click "Refresh dashboard"
   4. Make sure that all native filter requests were made after chart requests
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   
https://app.shortcut.com/preset/story/38199/refresh-dashboard-performance-issue-filter-requests-blocking-chart-requests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org