kgabryje commented on a change in pull request #19071:
URL: https://github.com/apache/superset/pull/19071#discussion_r822841418
##########
File path: superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
##########
@@ -108,6 +108,9 @@ const all_columns: typeof sharedControls.groupby = {
optionRenderer: c => <ColumnOption showType column={c} />,
valueRenderer: c => <ColumnOption column={c} />,
valueKey: 'column_name',
+ shouldMapStateToProps() {
Review comment:
Do we need it here and in `dnd_all_columns` and `percent_metrics`?
`mapStateToProps` has only 2 arguments, so we do not need to run it every time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
