villebro opened a new pull request #19088:
URL: https://github.com/apache/superset/pull/19088


   ### SUMMARY
   
   This PR extends the awesome work in #18562 by removing excluded charts from 
native filter configurations during importing. This can happen if a chart that 
was present when a native filter scope was defined is later removed from the 
dashboard.
   
   ### TESTING INSTRUCTIONS
   1. Import the exported dashboard from this PR: #19064
   2. See the `KeyError` that's raised (with this change the import is 
successful)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to