ktmud commented on pull request #19085: URL: https://github.com/apache/superset/pull/19085#issuecomment-1064286940
@michael-s-molina `sortComparator` does still work when users have a search string. It's just the parent component needs to presort the options with the same sortComparator. See the example in TimezoneSelector. I don't think I can clean it up yet for some filter components, either. I can clean up where `propertyComparator('order')` is used here, but would rather leave the complete clean up to another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org