codemaster08240328 opened a new pull request #19112: URL: https://github.com/apache/superset/pull/19112
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The Dashboard Import UI hangs when the operation fails - no error message is thrown to let the user know about it. **Behavior before update** The operation hangs. However, if you monitor the Network tab on the browser’s developer tools, you can check that the import request fails with a 500 error (Internal Server Error). **Expected results** The operation should thrown an error. <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **AFTER** <img width="1316" alt="image" src="https://user-images.githubusercontent.com/39701522/157770567-5826b37e-3ea1-4ef7-adee-e8c0134a5a35.png";> <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS 1. Create a simple Dashboard. 2. Export it. 3. Edit the ZIP file, deleting the datasets folder. 4. Try to import this modified ZIP in another Workspace. <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/39701522/157770567-5826b37e-3ea1-4ef7-adee-e8c0134a5a35.png"](https://user-images.githubusercontent.com/39701522/157770567-5826b37e-3ea1-4ef7-adee-e8c0134a5a35.png"){kind=link}