cccs-Dustin opened a new issue #19119:
URL: https://github.com/apache/superset/issues/19119


   **Is your feature request related to a problem? Please describe.**
   When users are creating a new dataset, if that dataset contains a field with 
a long, complex data type, users will get an error because the field type is 
too long. To get around this issue, users must change the field type to JSON. 
This can currently only be done (in the UI) through the Legacy Datasource 
Editor. It should be possible to do this through the new dataset editor as well.
   
   In the new dataset editor, even if a user wanted to simply change the 
column's data type from one data type to another, it is not currently possible. 
To do it, they need to go into the Legacy Datasource Editor, again, this should 
be possible in the new dataset editor.
   
   **Describe the solution you'd like**
   Within the front-end code, there is a prop for the `ColumnCollectionTable` 
component named `allowEditDataType`. It is currently always set to false, but 
if you manually change it to true and reload, you can modify the column's data 
type in the new dataset editor. So it seems like the implementation was almost 
complete, it was just never finished off. 
   
   My solution would include creating a new feature flag which would allow 
users to simply modify the config file instead of having to dig into the 
front-end code to enable this feature. I would also create unit tests to make 
sure that the UI behaves as expected when the flag is either enabled or 
disabled.
   
   
   Current dataset editor:
   ![Feature Flag 
Disabled](https://user-images.githubusercontent.com/96579982/157869524-48c08486-e9f4-4b7e-b74b-b56d6430bbcf.PNG)
   
   
   Proposed dataset editor with feature flag enabled:
   ![Feature Flag 
Enabled](https://user-images.githubusercontent.com/96579982/157869590-ef32addb-1019-416a-abf2-1c467e23423b.PNG)
   
   
   
   **Describe alternatives you've considered**
   Considering the prop is already in the component, I did not consider any 
other alternatives as the solution is pretty straightforward. 
   
   **Additional context**
   I have actually implemented the new feature flag and will create a PR for it 
to be added to master. When it has been created, I will link it here: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to