diegomedina248 opened a new pull request #19139:
URL: https://github.com/apache/superset/pull/19139


   ### SUMMARY
   Popovers are attached not to the triggers, but rather the overlay on the top 
of the page. This results in a few problems:
   * Pointers are not always accurate and do not point to the field they were 
triggered by
   * when user is scrolling through the control panel, the popover does not 
move and is floating in random places
   
   The solution does two things:
   * Blocks scrolling in the panel container while the popup is opened
   * Calculates the popover placement based on the trigger location in the 
screen.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
https://user-images.githubusercontent.com/17252075/158194589-3ed951fe-5000-43ff-8630-c31bfe287769.mov
   
   After:
   
https://user-images.githubusercontent.com/17252075/158194993-33140bfc-d3e6-4e6b-bd4f-d90753dd6770.mov
   
   ### TESTING INSTRUCTIONS
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to