kgabryje opened a new pull request #19236: URL: https://github.com/apache/superset/pull/19236
### SUMMARY 1. Due to incorrect import of fonts in `src/assets/stylesheets/less/fonts.less`, in fact only the fonts with normal font weight were available. That means that font weights other than 400 simply didn't work - weights from 200 to 500 were rendered as 400, bold font weights were extrapolated by the browser. This PR fixes that issue by explicitely importing font files with weights 200, 400, 500 and 600. 2. After the change described above, font-weight 700 (bold) was too thick. I replaced all 700 weights with 600, so that all texts look similar to how they looked before. 3. HTML tags `<h1-6>`, `<th>` and `<strong>` all use `font-weight: 700` by default. I've overriden them globally to use `font-weight: 600`. 4. I changed the value of bold font weight in `supersetTheme` from 700 to 600, because of the reasons described above. 5. I replaced hardcoded font weights in many components with superset theme variables. Only a few font weights in some plugins css files remain hardcoded. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS The changes affect the whole product - everything should look as it did before (if you compare side-by-side with current look, there are slight differences in how bold texts look - that's because we didn't actually use Inter font's bold version before). ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
