diegomedina248 opened a new pull request #19243: URL: https://github.com/apache/superset/pull/19243
### SUMMARY The `TabState` model has foreign key constraints on it that are not properly handled when the referred rows are deleted. This causes, for instance, that a database fails to be deleted if the user has an SQL Lab editor opened with a query referencing that database. This PR adds a database migration with `ondelete` instructions to properly handle cascading deletes when needed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS 1. Team member A previously has a SQL editor tab with DB1 2. Team member B (or same user might work as well) try to delete DB1 3. When prompted, confirm the deletion ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
