betodealmeida commented on pull request #19242: URL: https://github.com/apache/superset/pull/19242#issuecomment-1071385517
This looks great! I was confused by the behavior of `allow_adhoc_subquery`, so I left a suggestion on how to make it easier to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org