[GitHub] [superset] rusackas commented on a change in pull request #19122: fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

Fri, 18 Mar 2022 11:46:47 -0700 


rusackas commented on a change in pull request #19122:
URL: https://github.com/apache/superset/pull/19122#discussion_r830256078



##########
File path: superset-frontend/src/components/ReportModal/index.tsx
##########
@@ -250,9 +251,16 @@ const ReportModal: FunctionComponent<ReportProps> = ({
         await dispatch(addReport(newReportValues as ReportObject));
         onHide();
       } catch (e) {
-        const parsedError = await getClientErrorObject(e);
-        const errorMessage = parsedError.message;
-        onReducerChange(ActionType.error, errorMessage);
+        const { error } = await getClientErrorObject(e);
+        if (error) {

Review comment:
       For now, let's put the error at the bottom, like we do on the database 
connection modal. Consistency above all else!
   
   <img width="673" alt="image" 
src="https://user-images.githubusercontent.com/812905/159062588-e564b1c2-bc2c-4d18-8002-595505843f98.png";>
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to