villebro commented on a change in pull request #19232:
URL: https://github.com/apache/superset/pull/19232#discussion_r830449897
##########
File path: superset/utils/cache_manager.py
##########
@@ -40,27 +38,27 @@ def _init_cache(
) -> None:
cache_config = app.config[cache_config_key]
cache_type = cache_config.get("CACHE_TYPE")
- if app.debug and cache_type is None:
- cache_threshold = cache_config.get("CACHE_THRESHOLD", math.inf)
+ if required and cache_type in (None, "SupersetCache"):
+ if cache_type is None:
+ logger.warning(
+ "Falling back to the built-in cache, that stores data in
the "
Review comment:
We're not raising the warning unless `cache_type is None` (see a few
lines above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
