kasiazjc edited a comment on pull request #19257: URL: https://github.com/apache/superset/pull/19257#issuecomment-1075047997
> > Would it make sense to have it be a multiple select so that ALL your choices persist? Then removing an item from the selection could remove the preview just like clicking the close button above the field list itself (which is also not a consistent pattern in Superset, really). > > I totally agree with this. The ability to quickly remove one or all items without scrolling and keeping the behavior consistent with other Selects is essential. Right now, the behavior is really weird. I also agree with Diego's assessment that things look disconnected and need a design review (it's already happening). I think we should apply @rusackas suggestion before merging. > > Pinging @jess-dillard and @kasiazjc to consider this discussion in the new designs. I think the "after" is really confusing (and I would not recommend it) as there is no easy/immediate way to remove the selected schema table and you cannot quickly preview the selected schema tables. Is there a reason why this cannot be a multiple select and we added this flow instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
