diegomedina248 commented on a change in pull request #19316:
URL: https://github.com/apache/superset/pull/19316#discussion_r832531519
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -49,6 +50,10 @@ import {
unsetTimeFormattedColumn,
} from 'src/explore/actions/exploreActions';
+export const CellNull = styled('span')`
Review comment:
`styled.span` should work
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -306,6 +311,9 @@ export const useTableColumns = (
if (timeFormattedColumnIndex > -1) {
return timeFormatter(value);
}
+ if (value === null) {
Review comment:
I think this should be before the timeFormatter, if the value is NULL it
might crash it.
Can you test it out? (pass null directly or force it somehow, to see what
happens there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
