michael-s-molina commented on a change in pull request #19239:
URL: https://github.com/apache/superset/pull/19239#discussion_r833792637
##########
File path: superset-frontend/package.json
##########
@@ -126,6 +126,7 @@
"d3-scale": "^2.1.2",
"dom-to-image": "^2.6.0",
"emotion-rgba": "0.0.9",
+ "eslint-plugin-literal-colors": "file:eslint/eslint-plugin-literal-colors",
Review comment:
I'm still not sure about this name. Since this is a top-level folder, I
would really like to use the opportunity to name it more generically. In the
future, we could have sub-folders for `build`, `formatting`, etc. If not, at
least let's rename it to `build-tools` to follow the same plugin naming
convention.
I'm curious for @rusackas input here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
