diegomedina248 opened a new pull request #19362: URL: https://github.com/apache/superset/pull/19362
### SUMMARY In order to display the 'View Results' button in the history tab of the SQL Lab, the query must have a `resultsKey`. When the query is executed in sync mode, that key was not properly propagated from the API to the FE, thus, the button did not appeared after execution. The button did appeared once the running polling watching for queries updated, since that fetches fresh results from the api. This PR forwards that key to make the button show for every successfully executed query. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://user-images.githubusercontent.com/17252075/160002524-d03da706-ab0a-4d6f-b404-639fc12d5a73.mov After: https://user-images.githubusercontent.com/17252075/160002321-6feacd4d-c5af-4c91-8228-3a1858834d3d.mov ### TESTING INSTRUCTIONS 1. Configure a database for sync mode 2. Run queries in SQL Lab in that database 3. Check query history Ensure that, if the queries are successful, the 'View Results' button always displays. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
