zhaoyongjie commented on a change in pull request #19010:
URL: https://github.com/apache/superset/pull/19010#discussion_r834894044
##########
File path: superset-frontend/src/SqlLab/components/ResultSet/index.tsx
##########
@@ -278,7 +278,10 @@ export default class ResultSet extends React.PureComponent<
dbId,
datasetToOverwrite.datasetId,
sql,
- results.selected_columns.map(d => ({ column_name: d.name })),
+ results.selected_columns.map(d => ({
+ column_name: d.name,
+ is_dttm: d.is_date,
Review comment:
seems like `is_dttm` and `is_date` is inconsistency... Let me look at
more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
