[GitHub] [superset] diegomedina248 opened a new pull request #19370: fix(sql lab): replace the output column in the query history table

[GitBox]

diegomedina248 opened a new pull request #19370:
URL: https://github.com/apache/superset/pull/19370


   ### SUMMARY
   The current output column in the Query History table in the SQL Lab 
currently displays the schema if the query failed.
   The resulting UI is a column with "View results" button for successful 
queries and some seemingly random text if the query failed that lacks the 
appropriate context.
   
   This PR makes some cosmetic changes that include:
   * Removing the schema for failed queries and leaving the field blank
   * Renaming the column from "output" to "results"
   * Renaming the button for successful queries from "View results" to "View"
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="1289" alt="Screen Shot 2022-03-25 at 09 30 29" 
src="https://user-images.githubusercontent.com/17252075/160128737-0c957259-b7fe-49df-a61d-42ec335591ac.png";>
   
   After:
   <img width="1284" alt="Screen Shot 2022-03-25 at 09 48 22" 
src="https://user-images.githubusercontent.com/17252075/160128766-7acf76f2-2004-433b-b826-4f045fa20722.png";>
   
   ### TESTING INSTRUCTIONS
   1. Open the SQL Lab
   2. Execute valid and invalid queries
   
   Ensure the results column show the View button for successful queries & 
nothing for failed ones.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org