codemaster08240328 opened a new pull request #19371: URL: https://github.com/apache/superset/pull/19371
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> When enabling "sort bars" and disabling again, the order isn't reset to the original order. It was because when we sort data from props, it made updates in redux store as well. Solution: deep copy ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> BEFORE: <a href="https://www.loom.com/share/818b251b798946fa8fad094b95e34073";> <p>[DEV] Genders by State - 25 March 2022 - Watch Video</p> <img style="max-width:300px;" src="https://cdn.loom.com/sessions/thumbnails/818b251b798946fa8fad094b95e34073-with-play.gif";> </a> AFTER: <a href="https://www.loom.com/share/75005f3a14b24d63997bf2a13c8c8a6c";> <p>[DEV] Genders by State - 25 March 2022 - Watch Video</p> <img style="max-width:300px;" src="https://cdn.loom.com/sessions/thumbnails/75005f3a14b24d63997bf2a13c8c8a6c-with-play.gif";> </a> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Goto charts page 2. Select Genders by State chart 3. Check sort bars under customize tab. 4. Uncheck sort bars. 5. See how chart is rendered. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/12650 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://cdn.loom.com/sessions/thumbnails/818b251b798946fa8fad094b95e34073-with-play.gif"](https://cdn.loom.com/sessions/thumbnails/818b251b798946fa8fad094b95e34073-with-play.gif"){kind=link}
![https://cdn.loom.com/sessions/thumbnails/75005f3a14b24d63997bf2a13c8c8a6c-with-play.gif"](https://cdn.loom.com/sessions/thumbnails/75005f3a14b24d63997bf2a13c8c8a6c-with-play.gif"){kind=link}