villebro commented on a change in pull request #19393:
URL: https://github.com/apache/superset/pull/19393#discussion_r836353591
##########
File path:
superset-frontend/packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx
##########
@@ -170,6 +170,7 @@ export const advancedAnalyticsControls:
ControlPanelSectionConfig = {
choices: [
['asfreq', 'Null imputation'],
['zerofill', 'Zero imputation'],
+ ['linear', 'Linear imputation'],
Review comment:
nit:
```suggestion
['linear', 'Linear interpolation'],
```
##########
File path: superset/utils/pandas_postprocessing/utils.py
##########
@@ -92,6 +92,10 @@
"P1W/1970-01-04T00:00:00Z": "W",
}
+RESAMPLE_METHOD = tuple(
+ ["asfreq", "bfill", "ffill", "linear", "median", "mean", "sum",]
+)
Review comment:
any reason we can't just do this?
```suggestion
RESAMPLE_METHOD = ("asfreq", "bfill", "ffill", "linear", "median", "mean",
"sum")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
