prosdev0107 opened a new pull request #19429: URL: https://github.com/apache/superset/pull/19429
… dashboards <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Non certified dashboards appear on dashboard list when filtering by certified ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF BEFORE:  AFTER:  ### TESTING INSTRUCTIONS **How to reproduce the bug** 1. Certify some dashboards (This can be done from the dashboard CRUD view > edit > certified fields at the bottom of the modal) 2. Go to the dashboard list 3. Should show only certificated Dashboards when the filter option of certified is Yes. Generally, You will not reproduce this issue anymore with dashboard CRUD. This issue is happened when the certified_by field value is empty string, not null value.(like following image). and so I had a test after changing this forcely into empty string in some dashboards value and then could catch this issue and fix it.  ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
