lyndsiWilliams commented on a change in pull request #19314:
URL: https://github.com/apache/superset/pull/19314#discussion_r838829277
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -1252,6 +1430,24 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
/>
{renderPreferredSelector()}
{renderAvailableSelector()}
+ <Upload
+ name="databaseFile"
+ id="databaseFile"
+ data-test="database-file-input"
+ accept=".yaml,.json,.yml,.zip"
+ // upload is handled by hook
+ customRequest={() => {}}
+ onChange={info => onDbImport(info)}
Review comment:
Nevermind actually! I tried it locally just to see and I _don't_ have to
pass the param like I thought. I learned something today haha! Does that work
for any function passed in like this? Or does it only work if it takes just one
parameter?
Fixed in [`this
commit`](https://github.com/apache/superset/pull/19314/commits/71ebaf325d3c185a083a1f3c0a2818deb5d75208)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
