betodealmeida commented on a change in pull request #19454:
URL: https://github.com/apache/superset/pull/19454#discussion_r839169850
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1420,7 +1441,6 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
and db_engine_spec.allows_hidden_cc_in_orderby
and col.name in [select_col.name for select_col in
select_exprs]
):
- validate_adhoc_subquery(str(col.expression))
Review comment:
Moved this
[up](https://github.com/apache/superset/pull/19454/files#diff-af5e15a55ff9c81f441eb6b9b10dae13b2ee17fec614d3e3ad0057ed0dc814aeR1155-R1160),
where it's still a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
