lyndsiWilliams commented on a change in pull request #19314:
URL: https://github.com/apache/superset/pull/19314#discussion_r840043861
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -814,6 +863,25 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
</>
);
}
+
+ // Import doesn't use db state, so footer will not render in the if
statement above
+ if (importingModal) {
Review comment:
Oh whoops, good catch! Since importing databases don't use the db state,
the above if statement won't allow the footer to render when importing. I had
to make a separate identical footer for an importing database on 868, but I
forgot to take importingModal out of the check above. I removed it in [`this
commit`](https://github.com/apache/superset/pull/19314/commits/1420929e0965e06ca83f5e3df06c6d5db0a3872f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
