yousoph commented on pull request #19314:
URL: https://github.com/apache/superset/pull/19314#issuecomment-1086424570


   > let's test for a 500 error. I got a toast once, but not the second time. 
What should be the state of the modal on a 500? Stay on screen 1 
![Superset_and_Lumina](https://user-images.githubusercontent.com/5186919/161169246-0ea4e093-0f99-4459-9156-1b41373fa05e.png)
 ?
   Close modal and show error toast (in the future we should revisit showing 
errors on the modal itself) 
   
   Re: Import being not as discoverable - we don't think this is a primary 
action so we're ok with it as is for now (once it's updated to 14px instead of 
13px). Dashboard imports will be more common than db ones, but we can revisit 
later if we get more feedback that it's hard to find! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to