villebro commented on code in PR #19529:
URL: https://github.com/apache/superset/pull/19529#discussion_r842657536
##########
superset-frontend/src/explore/components/ExploreChartHeader/index.jsx:
##########
@@ -235,8 +238,18 @@ export class ExploreChartHeader extends
React.PureComponent {
this.props.chart.chartStatus,
);
return (
- <StyledHeader id="slice-header" className="panel-title-large">
+ <StyledHeader id="slice-header">
<div className="title-panel">
+ <ChartEditableTitle
+ title={this.getSliceName()}
+ canEdit={
+ !slice ||
+ this.props.can_overwrite ||
Review Comment:
nit: while we're using the destructured `slice`, could we also destructure
this like the others on line 224: `const { ..., can_overwrite: canOverwrite } =
this.props`. Also maybe `this.props.actions.updateChartTitle`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
