michael-s-molina commented on code in PR #19536:
URL: https://github.com/apache/superset/pull/19536#discussion_r843130117
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -277,59 +277,56 @@ class BigNumberVis extends
React.PureComponent<BigNumberVisProps> {
}
export default styled(BigNumberVis)`
- font-family: ${({ theme }) => theme.typography.families.sansSerif};
- position: relative;
- display: flex;
- flex-direction: column;
- justify-content: center;
-
- &.no-trendline .subheader-line {
- padding-bottom: 0.3em;
- }
-
- .text-container {
+ ${({ theme }) => `
+ font-family: ${theme.typography.families.sansSerif};
+ position: relative;
display: flex;
flex-direction: column;
justify-content: center;
- align-items: flex-start;
- .alert {
- font-size: ${({ theme }) => theme.typography.sizes.s};
- margin: -0.5em 0 0.4em;
- line-height: 1;
- padding: 2px 4px 3px;
- border-radius: 3px;
+
+ &.no-trendline .subheader-line {
+ padding-bottom: 0.3em;
Review Comment:
We need to keep `em` values because the font is scalling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
