villebro opened a new pull request, #19543:
URL: https://github.com/apache/superset/pull/19543

   ### SUMMARY
   Two migrations (`b92d69a6643c` and `0ca9e5f1dacd`) had been skipped in the 
1.4 release, causing errors when upgrading from 1.4 to 1.5 or master. See the 
different down revisions of `f9847149153d` in 1.4 and master:
   
   
https://github.com/apache/superset/blob/9fc5e09cb3c5278720d455ddde959ab791713206/superset/migrations/versions/f9847149153d_add_certifications_columns_to_slice.py#L29-L30
   
   
https://github.com/apache/superset/blob/156ac7dd79105bca47138d8906b50d01dc4f1cb6/superset/migrations/versions/f9847149153d_add_certifications_columns_to_slice.py#L29-L30
   
   This places the skipped migrations in front of the first migration of 1.5, 
making sure the migrations are applied to the metadata.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   1. Install version 1.4 of Superset, run db migrations
   2. Install 1.5.0rc1 or master branch, run db migrations and run `superset 
init` and see the error
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: closes #19100
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to