villebro opened a new pull request, #19557: URL: https://github.com/apache/superset/pull/19557
### SUMMARY The `adodbapi` dialect appears to be the only dialect included in `SQLAlchemy` 1.3 that doesn't implement the `dbapi()` method, and is fully removed in 1.4. To avoid logging a confusing warning, we should avoid trying to use the driver until we bump to 1.4. ### BEFORE Previous to this check, the following would regularly pop up on logs: 2022-04-06 13:31:24,380:WARNING:superset.db_engine_specs:Unable to load dialect <class 'sqlalchemy.dialects.mssql.adodbapi.MSDialect_adodbapi'>: type object 'MSDialect_adodbapi' has no attribute 'dbapi' ### TESTING INSTRUCTIONS Call `http://host/api/v1/database/available/` and make sure the you get the same available drivers as before, but no warning on the logs. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
