[GitHub] [superset] codemaster08240328 opened a new pull request, #19575: fix: Show full long number in text email report for table chart.

[GitBox]

codemaster08240328 opened a new pull request, #19575:
URL: https://github.com/apache/superset/pull/19575

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Before this update, when we have long number in text email report for table 
chart, report was not showing correct value.
   
   It was because `pd` converts long float value into `e` type. 
   
   In this pr, we added some display viz option into `pd`, so all long float 
value are displayed as a string.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   BEFORE:
   <img width="458" alt="image" 
src="https://user-images.githubusercontent.com/39701522/162058491-558fe7fe-291c-46b6-a130-fad22a7e56dd.png";>
   
   AFTER:
   <img width="373" alt="image" 
src="https://user-images.githubusercontent.com/39701522/162058433-5ef83edc-4d4f-4e8c-b0b7-09544e3487a6.png";>
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   1. Create a virtual dataset using this sql:
   ```
   select product_line, (sum(price_each)) * 12314 as Calculation
   from "Vehicle Sales"
   group by 1
   ```
   2. Create a table chart using Virtual Dataset.
   3. create a report sending this chart by email as text
   
   Check the email.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Bug fix
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org