villebro commented on PR #19572: URL: https://github.com/apache/superset/pull/19572#issuecomment-1091543412
Thanks for the contribution @dvchristianbors . While I agree this performance hit is very problematic, we currently rely heavily on `sqlparse` for some very critical validation logic. Therefore, some of the changes in this PR will not be possible in their current form. I looked into the original issue that you linked here, and noticed there seems to be open PRs on `sqlparse` that may address some of the observed performance issues. From our perspective, the optimal solution would be to fix the performance issues in the underlying library first, and only then optimize in Superset where needed. Out of curiosity, have you tested running Superset with a fork of `sqlparse` that has applied some of those open PRs? It would be interesting to see if they have a significant impact on performance.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
