zhaoyongjie commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845082492
##########
superset-frontend/src/views/CRUD/data/database/types.ts:
##########
@@ -79,7 +79,7 @@ export type DatabaseObject = {
// Extra
extra_json?: {
engine_params?: {
- catalog: Record<any, any> | string;
+ catalog?: Record<any, any> | string;
Review Comment:
`catalog` is an optional field in engine params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
