stevetracvc commented on code in PR #18009:
URL: https://github.com/apache/superset/pull/18009#discussion_r845242090
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx:
##########
@@ -149,6 +150,7 @@ export default function getControlItemsMap({
(controlItem: CustomControlItem) =>
controlItem?.config?.renderTrigger &&
controlItem.name !== 'sortAscending' &&
+ controlItem?.config?.type !== 'SelectControl' &&
Review Comment:
Oh I reread this and get it now. I guess the question is, how flexible
should these controls be? And since everything else is a checkbox, no one
bothered to check before. I'll make that change, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
