[GitHub] [superset] codemaster08240328 opened a new pull request, #19600: fix: Add 1 month to quaterly time grain

[GitBox]

codemaster08240328 opened a new pull request, #19600:
URL: https://github.com/apache/superset/pull/19600

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Before this change, we are facing wrong Q1, Q2, Q3, Q4 duration. 
   
   It should be
   Q1: Jan - Mar
   Q2: Apr - Jun
   Q3: Jul - Sep
   Q4: Oct - Dec
   
   The reason is that time grain expression against database returns date as 
the first date of each quarter. (e.g.: Q1: 1st Jan, Q2: 1st Apr). But when we 
visualize this data using time_series bar chart v2, the returned date is the 
middle date of the bar chart. 
   
   Solution: added 1 month to time grain expression for each database.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   <img width="1530" alt="image" 
src="https://user-images.githubusercontent.com/39701522/162277520-07970d5f-94a6-4648-9d51-2e845a9ef85f.png";>
   
   After:
   <img width="1532" alt="image" 
src="https://user-images.githubusercontent.com/39701522/162277294-94e264e6-04f8-4f51-b912-7022a50393c9.png";>
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   1. Chart a time series V2 chart using netflix demo data
      Time: Date added grain as day
      Metric: Count
      Time range: 01/01/2019 - 01/01/2020
   2. Run graph
   3. Toggle to “Quarter” time grain
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Bug fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org