[GitHub] [superset] diegomedina248 opened a new pull request, #19605: fix: Query execution time is displayed as invalid date

[GitBox]

diegomedina248 opened a new pull request, #19605:
URL: https://github.com/apache/superset/pull/19605

   ### SUMMARY
   The Time column in the Query History is being displayed as an Invalid date.
   
   The reason being the underlying data type is numeric with precision, to get 
sub-second precision.
   That means the returned json value is a string (to keep the precision) and 
in turn, it fails the conversion to a moment object.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   <img width="1728" alt="Screen Shot 2022-04-07 at 20 23 25" 
src="https://user-images.githubusercontent.com/17252075/162336157-b1eae912-8882-44d9-858c-dd9e79fbf88a.png";>
   
   After:
   <img width="1710" alt="new" 
src="https://user-images.githubusercontent.com/17252075/162336108-33aeaf4a-6f8f-469d-a39d-115894339ec8.png";>
   
   ### TESTING INSTRUCTIONS
   1. Go to SQL lab -> SQL Editor
   2. Run any query
   3. Go to SQL lab -> Query History
   
   Ensure the time column is displaying the proper start time.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org