villebro commented on code in PR #19622:
URL: https://github.com/apache/superset/pull/19622#discussion_r846974094
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts:
##########
@@ -248,6 +311,18 @@ export default function transformProps(
...getLegendProps(legendType, legendOrientation, showLegend),
data: keys,
},
+ graphic: showTotal
+ ? {
+ type: 'text',
+ ...getTotalValuePadding({ chartPadding, donut, width, height }),
+ style: {
+ text: t(`Total: ${numberFormatter(totalValue)}`),
Review Comment:
Late to the party, but translated strings need to be constant. This needs to
be something like:
```js
t('Total: %s', numberFormatter(totalValue))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
