jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r847795104
##########
RELEASING/changelog.py:
##########
@@ -24,9 +24,9 @@
from click.core import Context
try:
- from github import BadCredentialsException, Github, PullRequest, Repository
+ from github import BadCredentialsException, GitHub, PullRequest, Repository
except ModuleNotFoundError:
- print("PyGithub is a required package for this script")
+ print("PyGitHub is a required package for this script")
exit(1)
Review Comment:
Tested.
Apparently the project does at least occasionally call itself **PyGitHub**:
https://github.com/PyGithub/PyGithub/blob/001970d4a828017f704f6744a5775b4207a6523c/README.md?plain=1#L1
But, the classes/exceptions/methods aren't exposed via the proper spelling,
so I'll have to fix up this commit (dropping most of the Python bits, but
keeping the change for line 29).
---
As an aside, I can't get `pip install -r ...` to work, it dies on my m1
trying to do stuff using numpy (amd64 stuff at that!!):
```
numpy/core/src/multiarray/scalartypes.c.src:2967:65: error: too
few arguments to function call, expected 2, have 1
return _Py_HashDouble((double) PyArrayScalar_VAL(obj,
Float));
~~~~~~~~~~~~~~ ^
```
I've tried a couple of versions of numpy and that didn't help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
