kgabryje commented on code in PR #19651:
URL: https://github.com/apache/superset/pull/19651#discussion_r848368297
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx:
##########
@@ -127,14 +127,7 @@ export function DndColumnSelect(props:
DndColumnSelectProps) {
);
const popoverOptions = useMemo(
- () =>
- Object.values(options).filter(
- col =>
- !optionSelector.values
- .filter(isColumnMeta)
- .map((val: ColumnMeta) => val.column_name)
- .includes(col.column_name),
Review Comment:
It was supposed to filter out the current value from options when editing
metric/column/filter. I suppose we don't really need it so lgtm 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
