codemaster08240328 opened a new pull request, #19692: URL: https://github.com/apache/superset/pull/19692
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> - Change the shortcut for Stop Query from Control + X to Control + E on PC / Linux - Update the tooltip text on the stop query button to reflect the shortcut change - Mac shortcut should remain the same as it is today (Control+X) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Go to SqlLab 2. Run any query 3. Try to press ctrl + e(on PC, Linux) or ctrl + x (on Mac) 4. Check tool tip when hovering on `Stop query` button ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/9990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
