villebro commented on PR #19624: URL: https://github.com/apache/superset/pull/19624#issuecomment-1100064749
> Would you mind adding unit tests—or the bare minimum testing instructions—especially given the previous change resulted in a regression. We should strive to harden the robustness/quality of the product. @pkdotson sorry for not having noticed this fix (I just needed to get it fixed for 1.5.0rc3). @john-bodley this would have been caught if the file was TypeScript. This is a good reminder of why we need to keep migrating those pesky `.js*` files to `.ts*`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
