villebro opened a new pull request, #19749:
URL: https://github.com/apache/superset/pull/19749

   ### SUMMARY
   Currently the util function that fetches the permalink salt is memoized. 
This can cause trouble if the workers need to reference different metastores. 
While removal of the `memoized` decorator will have a performance impact, it 
should be negligible, as it's very light weight and occurs fairly infrequently. 
I will look into a better solution for avoiding refetching the salt on each 
permalink action.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Decoding a permalink with a salt different to that with which it was 
encrypted results in the following error:
   <img width="1271" alt="image" 
src="https://user-images.githubusercontent.com/33317356/163769791-8ae96dbc-f06d-45bd-9f8b-a77820201e35.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to