dpgaspar opened a new pull request, #19754: URL: https://github.com/apache/superset/pull/19754
### SUMMARY Following plan to gradually deprecate "REST" endpoints on `/superset` namespace. Deprecates `/superset//fave_dashboards/<int:user_id>/`. Proposed removal on Superset 3.0 Deprecates `/fave_dashboards_by_username/<username>/`. Proposed removal on Superset 3.0 Replaced by an existing endpoint /api/v1/dashboard/, includes the necessary frontend migration. NOTE: The use of the generic get list endpoint will not fetch the date where the dashboard was favorited, this would force us to create a new endpoint specifically for this query or always enforce N+1 queries on the get list (not an option). Replaced this date by the humanised version of the dashboard creation date. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> After: <img width="873" alt="Screenshot 2022-04-18 at 12 17 21" src="https://user-images.githubusercontent.com/4025227/163800851-01938198-94b9-4934-9de7-10af8cb349d3.png";> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/4025227/163800851-01938198-94b9-4934-9de7-10af8cb349d3.png"](https://user-images.githubusercontent.com/4025227/163800851-01938198-94b9-4934-9de7-10af8cb349d3.png"){kind=link}