villebro commented on PR #17903:
URL: https://github.com/apache/superset/pull/17903#issuecomment-1103508194
@jdbranham there's a few minor lint issues, here's the diff which should fix
the remaining errors:
```patch
diff --git
a/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/buildQuery.test.ts
b/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/buildQuery.test.ts
index d7c0457dfa..ec0eb1bae2 100644
---
a/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/buildQuery.test.ts
+++
b/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/buildQuery.test.ts
@@ -7,8 +7,8 @@ describe('Handlebars buildQuery', () => {
granularitySqla: 'ds',
groupby: ['foo'],
viz_type: 'my_chart',
- width: '500px',
- height: '500px'
+ width: 500,
+ height: 500,
};
it('should build groupby with series in form data', () => {
diff --git
a/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/transformProps.test.ts
b/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/transformProps.test.ts
index f24d2c29f4..b5dc643529 100644
---
a/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/transformProps.test.ts
+++
b/superset-frontend/plugins/plugin-chart-handlebars/test/plugin/transformProps.test.ts
@@ -9,8 +9,9 @@ describe('Handlebars tranformProps', () => {
granularitySqla: 'ds',
metric: 'sum__num',
groupby: ['name'],
- width: '500px',
- height: '500px'
+ width: 500,
+ height: 500,
+ viz_type: 'handlebars',
};
const chartProps = new ChartProps<QueryFormData>({
formData,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
